Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add links to badges #675

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 8, 2024

Describe your changes

Right now, clicking the badges takes you to the badge image.

Instead, link to a relevant webpage (like pytest-memray does).

Testing performed

Went to https://github.com/hugovk/memray/tree/readme-badge-links?tab=readme-ov-file and clicked 'em all.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (5d9e04d) to head (8c3c6d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   93.03%   92.92%   -0.12%     
==========================================
  Files          94       94              
  Lines       11445    11445              
  Branches     2114     2114              
==========================================
- Hits        10648    10635      -13     
- Misses        797      810      +13     
Flag Coverage Δ
cpp 92.92% <ø> (-0.12%) ⬇️
python_and_cython 92.92% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Hugo van Kemenade <[email protected]>
@pablogsal
Copy link
Member

Thanks a lot @hugovk ❤️

@pablogsal pablogsal merged commit 1b3cf6e into bloomberg:main Sep 9, 2024
15 checks passed
@hugovk hugovk deleted the readme-badge-links branch September 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants